-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
boards: add nimble defconfig to esp32c3-generic #15187
Conversation
[Experimental Bot, please feedback here] No, this PR does not fully meet the NuttX requirements. While it provides a summary of the change, it lacks crucial information. Here's a breakdown of what's missing:
To make this PR compliant, you need to add the missing information in each section. For example: Example of a more complete Summary:
Example of a more complete Impact:
Example of more complete Testing:
By filling in the missing information like this, your PR will better meet the requirements and be easier for reviewers to assess. |
@Laczen please take a look at this issue:
|
This is a bit annoying, the correction of this error (if at all possible) is done in a different repo (nuttx-apps). |
@Laczen I see that you don't configure any BLE role for nimble. Probably this is why this warning happens, and probably this is why you need |
Add a configuration for ble using nimble on esp32c3-generic Signed-off-by: Laczen JMS <[email protected]>
Modify documentation of esp32c3 and add nimble section to esp32c3-generic. Signed-off-by: Laczen JMS <[email protected]>
1c640d7
to
3d84e68
Compare
@acassis, it seems the PR is still failing CI. How can I see the error, I've tried looking at the build failure output, but the failure is unclear for me. |
@Laczen The error is caused by something else:
Which we're still fixing (sorry I'm a bit overloaded sigh): FYI If we're not sure if our PR is causing the CI Build to fail, we might check nuttx-dashboard.org. This shows that rv-virt/citest is indeed broken, so it's not because of our PR :-) |
@acassis should I rebase? |
@Laczen There's a problem with CITest, I'm patching it here: |
Ok, if I need to rebase just let me know. |
Sorry @Laczen could you rebase with master? It should fix the |
Note: Please adhere to Contributing Guidelines.
Summary
Provide nimble configuration for esp32c3.
Impact
Testing
Verified on wsl2: ubuntu 22.04